Turn off SIV after the first block on process_file#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We disable the SIV initialisation after the first block is processed in
process_file. The SIV mechanism is used to make the encryption more resilient to accidental seed reuse. Given the seed evolution employed by VernamVeil, it only makes sense to have this feature on for the first block and disable it for subsequent blocks.On macOS 4-6% speed up on a 1GB file:
Though up to now, I report benchmarks on PRs for both mac and Linux, I'll stop reporting the main benchmarks on Linux primarily because my Linux machine is a bit dated and its hardware produces high-variance measurements. MacOS is far more consistent across benchmarks, making comparisons clearer. For PRs that affect x86 instructions, I might consider an AWS instance.